Skip to content

Windows sigalarm fix - #624 - #625

Merged
NeptuneHub merged 4 commits into
mainfrom
devel
Jun 10, 2026
Merged

Windows sigalarm fix - #624#625
NeptuneHub merged 4 commits into
mainfrom
devel

Conversation

@NeptuneHub

@NeptuneHub NeptuneHub commented Jun 10, 2026

Copy link
Copy Markdown
Owner

This PR is a windows sigalarm fix related to bug #624

PR test builds:

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a Windows compatibility issue in RQ where the hardcoded UnixSignalDeathPenalty causes an AttributeError during job registry cleanup. The changes configure BaseRegistry and the queues to use the platform-appropriate death penalty class via get_default_death_penalty_class(). Unit tests have also been added to verify this behavior. No review comments were provided, so there is no additional feedback to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@NeptuneHub
NeptuneHub merged commit 6848884 into main Jun 10, 2026
15 of 17 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant